ct-public/isparkclaw-webui
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Nous static models use @nous: prefix — v0.50.164 (#885)

Browse Source 
fix: Nous static models use @nous: prefix — v0.50.164 (#885)

Follow-up to #854 / PR #870. The previous fix made Nous static IDs
slash-prefixed and added a portal-guard branch to resolve_model_provider().
This tightens the static list to use the explicit @nous: prefix, matching
the format of live-fetched models after ui.js's _fetchLiveModels() portal-
prefix step.

The @provider:model branch in resolve_model_provider() is more explicit and
reliable than the portal-guard fallback. Both static and live-fetched paths
now converge on the same resolver output — and as a side effect, the dedup
check in _fetchLiveModels() now correctly identifies static entries as already
present, eliminating duplicate entries in the dropdown for Nous users.

Verified: all 29 Nous models in the browser dropdown carry @nous: prefix,
routing confirmed correct via resolve_model_provider() for all 4 static IDs,
1941 tests passing.

Closes #854.
This commit is contained in:
nesquena-hermes
2026-04-22 22:56:21 -07:00
committed by GitHub
parent d39d30a213
commit 666d385c03
3 changed files with 38 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
tests/test_nous_portal_routing.py
View File

@@ -36,45 +36,54 @@ def _models_with_provider(provider, monkeypatch):
class TestNousModelIds:
"""Nous static model IDs must be slash-prefixed for Nous API compatibility."""
"""Nous static model IDs must use @nous: prefix for explicit portal routing."""
def test_nous_models_use_slash_prefixed_ids(self):
"""All Nous static models must carry a provider/model slash prefix."""
def test_nous_models_use_at_prefix(self):
"""All Nous static models must carry the @nous: explicit provider prefix.
This ensures they route through the @provider:model branch of
resolve_model_provider() — identical to the live-fetched path — rather
than relying on the slash-only portal provider guard.
"""
from api.config import _PROVIDER_MODELS
nous_models = _PROVIDER_MODELS.get("nous", [])
assert nous_models, "Nous must have at least one static model"
for m in nous_models:
mid = m["id"]
assert "/" in mid, (
f"Nous model '{mid}' must be in provider/model format "
f"(e.g. anthropic/claude-opus-4.6) so Nous routes it correctly. "
f"Bare names cause Nous to reject the request."
assert mid.startswith("@nous:"), (
f"Nous model '{mid}' must start with '@nous:' "
f"(e.g. @nous:anthropic/claude-opus-4.6) so it routes through "
f"the explicit provider hint branch, not the weaker portal guard."
)
def test_nous_known_models_present(self):
"""Key Nous models must be present with correct slash-prefixed IDs."""
"""Key Nous models must be present with correct @nous:-prefixed IDs."""
from api.config import _PROVIDER_MODELS
nous_ids = {m["id"] for m in _PROVIDER_MODELS.get("nous", [])}
assert "anthropic/claude-opus-4.6" in nous_ids, (
"anthropic/claude-opus-4.6 must be in Nous model list"
assert "@nous:anthropic/claude-opus-4.6" in nous_ids, (
"@nous:anthropic/claude-opus-4.6 must be in Nous model list"
)
assert "anthropic/claude-sonnet-4.6" in nous_ids, (
"anthropic/claude-sonnet-4.6 must be in Nous model list"
assert "@nous:anthropic/claude-sonnet-4.6" in nous_ids, (
"@nous:anthropic/claude-sonnet-4.6 must be in Nous model list"
)
assert "openai/gpt-5.4-mini" in nous_ids, (
"openai/gpt-5.4-mini must be in Nous model list"
assert "@nous:openai/gpt-5.4-mini" in nous_ids, (
"@nous:openai/gpt-5.4-mini must be in Nous model list"
)
def test_nous_models_no_bare_names(self):
"""No Nous model should use a bare name without a slash prefix."""
def test_nous_models_no_bare_or_slash_only(self):
"""No Nous static model should be bare or slash-only without @nous: prefix."""
from api.config import _PROVIDER_MODELS
bare_names = {"claude-opus-4.6", "claude-sonnet-4.6", "gpt-5.4-mini",
"gemini-3.1-pro-preview"}
bad_ids = {
"claude-opus-4.6", "claude-sonnet-4.6", "gpt-5.4-mini",
"gemini-3.1-pro-preview",
"anthropic/claude-opus-4.6", "anthropic/claude-sonnet-4.6",
"openai/gpt-5.4-mini", "google/gemini-3.1-pro-preview",
}
nous_ids = {m["id"] for m in _PROVIDER_MODELS.get("nous", [])}
for bare in bare_names:
assert bare not in nous_ids, (
f"Bare model ID '{bare}' found in Nous model list. "
f"Must be slash-prefixed (e.g. anthropic/{bare})."
for bad in bad_ids:
assert bad not in nous_ids, (
f"Model ID '{bad}' found in Nous static list without @nous: prefix. "
f"Use '@nous:{bad}' so routing matches the live-fetched path."
)